Skip to content

Conversation

@lumasepa
Copy link
Contributor

Implementation for #1266

@lumasepa lumasepa requested a review from a team as a code owner June 22, 2023 15:59
@lumasepa lumasepa force-pushed the feature/allow-to-run-arbitrary-commands branch from 1fb1f17 to f09361c Compare June 22, 2023 16:15
@lumasepa lumasepa changed the title Allow to run arbitrary commands in conainers using cross-util run ... Allow to run arbitrary commands in containers using cross-util run ... Jun 22, 2023
@lumasepa lumasepa force-pushed the feature/allow-to-run-arbitrary-commands branch 2 times, most recently from 9623db9 to 278c3ea Compare June 22, 2023 16:49
@lumasepa lumasepa force-pushed the feature/allow-to-run-arbitrary-commands branch from 278c3ea to be92c3f Compare June 22, 2023 16:55
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, some pointers

@lumasepa lumasepa force-pushed the feature/allow-to-run-arbitrary-commands branch from 7e46941 to 00c39a6 Compare June 23, 2023 10:45
@lumasepa
Copy link
Contributor Author

The changelog check is failing, I added a line in the changelog. Any suggestions on how to fix it?

@Emilgardis
Copy link
Member

Emilgardis commented Jun 23, 2023

See https://github.com/cross-rs/cross/blob/main/.changes/README.md for how to make a changelog entry :)

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! fix the changeog and this should be good to go!

@lumasepa lumasepa force-pushed the feature/allow-to-run-arbitrary-commands branch from 00c39a6 to 1aab4cf Compare June 26, 2023 08:08
@lumasepa
Copy link
Contributor Author

See https://github.com/cross-rs/cross/blob/main/.changes/README.md for how to make a changelog entry :)

Thanks, done 😄

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you :)

bors r+

bors bot added a commit that referenced this pull request Jun 27, 2023
1280: Allow to run arbitrary commands in containers using cross-util run ... r=Emilgardis a=lumasepa

Implementation for #1266

Co-authored-by: Sergio Medina <[email protected]>
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect or should skip any cross-compilation targets. label Jun 27, 2023
@Emilgardis
Copy link
Member

I keep forgetting some targets are broken...

bors cancel

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ci-targets PRs that do not affect or should skip any cross-compilation targets.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants